IBX-7502: Added file size validation for image asset field type #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ciastektk
commented
Jan 10, 2024
ciastektk
force-pushed
the
ibx-7502-added-file-size-validation-for-image-asset
branch
from
ada6b9d to
12ddb47
Compare
Steveb-p
approved these changes
Jan 12, 2024
| (int)$content->contentInfo->contentTypeId | ||
| ); | ||
|
|
||
| if ($this->assetMapper->isAsset($content)) { |
There was a problem hiding this comment.
Prefer an early return instead, if Content is not an asset and we cannot continue with validation.
alongosz
approved these changes
Jan 12, 2024
ViniTou
approved these changes
Jan 12, 2024
konradoboza
approved these changes
Jan 15, 2024
Co-authored-by: Konrad Oboza <[email protected]>
|
micszo
approved these changes
Jan 16, 2024
alongosz
deleted the
ibx-7502-added-file-size-validation-for-image-asset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6Ref: ibexa/content-forms#61
This PR adds file size validation to image asset field type definition, base on validation settings from ezimage field type. Currently validation is added as Symfony File validator in: https://github.com/ibexa/content-forms/blob/main/src/lib/Form/Type/FieldType/ImageAssetFieldType.php#L82-L86.
Checklist:
$ composer fix-cs).@ibexa/engineering).